Skip to content

Terms Query: Remove block bindings #72275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntsekouras merged 2 commits into from
Oct 13, 2025
Merged

Terms Query: Remove block bindings #72275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb9f5f
Terms Query: Remove block bindings
ntsekouras Oct 13, 2025
2c41287
feedback
ntsekouras Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions backport-changelog/6.9/9356.md
View file
Open in desktop

This file was deleted.

96 changes: 0 additions & 96 deletions lib/compat/wordpress-6.9/term-data-block-bindings.php
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lib/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ function gutenberg_is_experiment_enabled( $name ) {
require __DIR__ . '/compat/wordpress-6.9/template-activate.php';
require __DIR__ . '/compat/wordpress-6.9/block-bindings.php';
require __DIR__ . '/compat/wordpress-6.9/post-data-block-bindings.php';
require __DIR__ . '/compat/wordpress-6.9/term-data-block-bindings.php';
require __DIR__ . '/compat/wordpress-6.9/entity-block-bindings.php';
require __DIR__ . '/compat/wordpress-6.9/rest-api.php';
require __DIR__ . '/compat/wordpress-6.9/class-gutenberg-hierarchical-sort.php';
Expand Down
19 changes: 1 addition & 18 deletions packages/block-library/src/term-template/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,7 @@ import {
} from '@wordpress/block-editor';
import { useEntityRecords } from '@wordpress/core-data';

const TEMPLATE = [
[
'core/paragraph',
{
metadata: {
name: __( 'Term Name' ),
bindings: {
content: {
source: 'core/term-data',
args: {
key: 'name',
},
},
},
},
},
],
];
const TEMPLATE = [ [ 'core/term-name' ] ];

function TermTemplateInnerBlocks( { classList } ) {
const innerBlocksProps = useInnerBlocksProps(
Expand Down
38 changes: 2 additions & 36 deletions packages/block-library/src/terms-query/variations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,40 +16,6 @@ export const titleExcerpt = (
</SVG>
);

const termName = [
'core/paragraph',
{
metadata: {
name: __( 'Term Name' ),
bindings: {
content: {
source: 'core/term-data',
args: {
key: 'name',
},
},
},
},
},
];
const termCount = [
'core/paragraph',
{
placeholder: __( '(count)' ),
metadata: {
name: __( 'Term Count' ),
bindings: {
content: {
source: 'core/term-data',
args: {
key: 'count',
},
},
},
},
},
];

const variations = [
{
name: 'title',
Expand All @@ -58,7 +24,7 @@ const variations = [
attributes: {},
icon: titleDate,
scope: [ 'block' ],
innerBlocks: [ [ 'core/term-template', {}, [ termName ] ] ],
innerBlocks: [ [ 'core/term-template', {}, [ [ 'core/term-name' ] ] ] ],
},
{
name: 'title-count',
Expand All @@ -77,7 +43,7 @@ const variations = [
[
'core/group',
{ layout: { type: 'flex', flexWrap: 'nowrap' } },
[ termName, termCount ],
[ [ 'core/term-name' ], [ 'core/term-count' ] ],
],
],
],
Expand Down
2 changes: 0 additions & 2 deletions packages/editor/src/bindings/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { registerBlockBindingsSource } from '@wordpress/blocks';
import patternOverrides from './pattern-overrides';
import postData from './post-data';
import postMeta from './post-meta';
import termData from './term-data';
import entity from './entity';

/**
Expand All @@ -26,6 +25,5 @@ export function registerCoreBlockBindingsSources() {
registerBlockBindingsSource( patternOverrides );
registerBlockBindingsSource( postData );
registerBlockBindingsSource( postMeta );
registerBlockBindingsSource( termData );
registerBlockBindingsSource( entity );
}
178 changes: 0 additions & 178 deletions packages/editor/src/bindings/term-data.js
View file
Open in desktop

This file was deleted.

Loading