Template activation: clear notice on post change #72403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -9 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 83ec2e9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18599678609
|
Mamaduka
approved these changes
Oct 17, 2025
mcsf
reviewed
Oct 17, 2025
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
This is hacky, but maybe that's worth the user benefit?
How will we keep track of this in the long term? Are there other notices across the system that should also be cleared? Etc.
Feel free to merge despite my questions.
Member
Author
Yes, that's why I suggested the other solution with EditorNotices, but that also has downsides. Like what if it doesn't remount and the ID just switches. Also yes I think there must be problems with other "sticky" notices. |
Co-authored-by: Miguel Fonseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #72285 (comment)
Remove the template activation notice when the post in the editor changes.
Why?
The notice currently lingers: when you open another template the notice is still there.
How?
I'm not sure if it's the best solution tbh. Alternatively we could remove the notice when
EditorNoticesunmounts. 🤔Testing Instructions
Edit an inactive template. Save. Observe the notice, optionally activate. Now go back to the list and activate editor another template. The notice shouldn't be there.
Testing Instructions for Keyboard
Screenshots or screencast