Skip to content

Reuse wp_script_attributes filter for adding data-wp-router-options attribute to script module #72489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luisherranz merged 20 commits into from
Oct 22, 2025
Merged

Reuse wp_script_attributes filter for adding data-wp-router-options attribute to script module #72489

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
04f073d
Reuse wp_script_attributes filter for adding data-wp-router-options a…
westonruter Oct 17, 2025
d14f94b
Use wp_json_encode()
westonruter Oct 17, 2025
ac4e28e
Make gutenberg_script_module_add_router_options_attributes() more con…
westonruter Oct 17, 2025
67db04c
Improve phpdoc return tags
westonruter Oct 17, 2025
ffc4cc4
Remove compat/wordpress-6.9/script-modules.php
westonruter Oct 17, 2025
4d07b05
Update backport changelog
westonruter Oct 17, 2025
5e78cd1
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into u…
westonruter Oct 17, 2025
e519c02
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into u…
westonruter Oct 18, 2025
1b164c3
(WIP) Use render_block_data to filter all blocks
luisherranz Oct 20, 2025
2300793
Adjust manual registration of blocks in e2e tests
samueljseay Oct 20, 2025
5d5f35c
We should not need any manual registration now.
samueljseay Oct 21, 2025
43fe04f
Update changelog to match new wordpress-develop PR.
samueljseay Oct 21, 2025
8cb5456
Merge remote-tracking branch 'origin/trunk' into update/script-module…
samueljseay Oct 21, 2025
4b03144
Fix merge conflict mistake
samueljseay Oct 21, 2025
b7c8664
Remove redundant white space change
samueljseay Oct 21, 2025
dcb4834
Fix merge conflict mistake
samueljseay Oct 21, 2025
a46140a
Move conditional code to compat, check for existence of new method wh…
samueljseay Oct 21, 2025
9be1729
Merge remote-tracking branch 'fork/master' into update/script-module-…
samueljseay Oct 22, 2025
0e27a2e
Fix typo in code comment.
samueljseay Oct 22, 2025
00ae9f6
Simplify the compatibility check.
samueljseay Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify the compatibility check.
  • Loading branch information
@samueljseay
samueljseay committed Oct 22, 2025
commit 00ae9f60248c46285b2aaa5391d5222ed66d91c8
6 changes: 2 additions & 4 deletions lib/client-assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,10 +694,8 @@ function gutenberg_default_script_modules() {
'fetchpriority' => 'low',
);

if ( function_exists( 'wp_interactivity' ) && method_exists( wp_interactivity(), 'add_client_navigation_support_to_script_module' ) ) {
if ( str_starts_with( $script_module_id, '@wordpress/block-library' ) ) {
wp_interactivity()->add_client_navigation_support_to_script_module( $script_module_id );
}
if ( str_starts_with( $script_module_id, '@wordpress/block-library' ) && method_exists( 'WP_Interactivity_API', 'add_client_navigation_support_to_script_module' ) ) {
wp_interactivity()->add_client_navigation_support_to_script_module( $script_module_id );
}

$path = gutenberg_url( "build/modules/{$file_name}" );
Expand Down
2 changes: 1 addition & 1 deletion lib/compat/wordpress-6.9/client-assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* @package gutenberg
*/

if ( version_compare( get_bloginfo( 'version' ), '6.9.0', '<' ) ) {
if ( ! method_exists( 'WP_Interactivity_API', 'add_client_navigation_support_to_script_module' ) ) {
/**
* Access the shared static variable for interactive script modules.
*
Expand Down
Loading