Template activation: improve UX for custom templates #72499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +121 B (+0.01%) Total Size: 2.17 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 40f6654. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18657764424
|
juanfra
reviewed
Oct 21, 2025
Member
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left a couple of comments.
Comment on lines
158
to
161
| if ( item.is_custom ) { | ||
| // translators: Refers to a type of template: custom template | ||
| return <Badge intent="info">{ __( 'Custom' ) }</Badge>; | ||
| } |
Member
There was a problem hiding this comment.
As a site admin, I might not fully understand what “Custom” means when it appears next to the status. I’d associate “Custom” with a template type instead, which is also pixels away from the status, and could feel redundant.
My expectation would be to see the actual status (active or inactive) and, if the template type is custom, get some context on why I can or can’t make changes.
Maybe a padlock icon on the active/inactive status for custom templates, with a tooltip explaining the limitation, could work well here.
Also, labeling a status as “Custom” might suggest it’s something I can create or edit, which could be confusing.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback, @juanfra!
My initial version had a more basic "N/A" label instead. Because custom templates really don't have a status. At least right now they don't; maybe at some point we could attempt to track them to posts that use them, but none of that is built.
padlock icon
From a design / components standpoint, I don't know if we can do this, I'd like input from designers.
with a tooltip explaining the limitation, could work well here
This makes perfect sense, I think we should. However, I'm working with @ellatrix and we'd like to merge something imperfect now and polish those interactions during the Beta cycle.
I'll quickly address the _x() part, but I hope you can approve this more or less as-is. Yay or nay on the "N/A" label?
Member
There was a problem hiding this comment.
Thanks for the response, Miguel! I understand the urgency with 6.9 around the corner, so I agree that “N/A” works better than the “Custom” approach. I’m good approving this as-is, with the hope that we can revisit and refine it in the future.
priethor
added
Backport to WP 6.9 Beta/RC
mcsf
commented
Oct 21, 2025
Comment on lines
+158
to
+162
| record.is_custom || | ||
| ( ! record.meta?.is_wp_suggestion && | ||
| ! defaultTemplateTypes.find( | ||
| ( type ) => type.slug === record.slug | ||
| ) ), |
Contributor
Author
There was a problem hiding this comment.
Adapted from
gutenberg/packages/editor/src/components/post-template/hooks.js
Lines 95 to 102 in c1f90a6
ellatrix
approved these changes
Oct 21, 2025
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Works, tested both created and registered templates.
ellatrix
reviewed
Oct 21, 2025
mcsf
force-pushed
the
fix/template-activation-for-custom-templates
branch
from
dde4c04 to
86181d3
Compare
- Avoid "Custom" label for template status - Add a tentative "title" attribute to the status badge for custom templates - Use _x() where appropriate
We'll want to expose this via REST API, most likely.
mcsf
force-pushed
the
fix/template-activation-for-custom-templates
branch
from
86181d3 to
987422f
Compare
priethor
approved these changes
Oct 21, 2025
Contributor
There was a problem hiding this comment.
The failing tests are unrelated to this PR and started failing in trunk earlier today, seemingly after #72487. Let's merge this without those tests passing to get ready for Beta1.
Member
|
Yes These are failing on trunk too and we need this PR to get merged and included in a package asap. Let's merge. I will skip the performance test too. |
priethor
added a commit
that referenced
this pull request
Oct 21, 2025
Co-authored-by: mcsf <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: priethor < [email protected]>
Contributor
|
I just cherry-picked this PR to the wp/latest branch to get it included in the next release: 116f67e |
priethor
removed
the
Backport to WP 6.9 Beta/RC
priethor
added a commit
that referenced
this pull request
Oct 21, 2025
Co-authored-by: mcsf <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: priethor < [email protected]>
Contributor
|
I just cherry-picked this PR to the release/21.9 branch to get it included in the next release: a608ced |
priethor
removed
the
Backport to Gutenberg RC
tyxla
reviewed
Oct 31, 2025
| <Badge | ||
| intent="info" | ||
| title={ __( | ||
| 'Custom templates cannot be active nor inactive.' |
Member
There was a problem hiding this comment.
Worth double-checking, but I think this is grammatically wrong, and it should be this instead:
Custom templates cannot be active or inactive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up of #67125
In the template editor:
Why?
Custom templates aren't part of the template hierarchy and thus aren't subject to activation. The actions available and UI should reflect this.
Questions
intent="info"to set custom templates apart from deactivated templates. What do you think of this? Happy to remove it and let the default take over.Screenshots or screencast