Skip to content

Template activation: remove the ability to deactivate registered templates #72636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 3 commits into from
Oct 27, 2025
Merged

Template activation: remove the ability to deactivate registered templates #72636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83b68c3
template activation: remove the ability to deactivate default templates
ellatrix Oct 23, 2025
3ae7138
Fix e2e
ellatrix Oct 24, 2025
9874f0a
backport log
ellatrix Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix e2e
  • Loading branch information
@ellatrix
ellatrix committed Oct 27, 2025
commit 3ae713800f3a443a4d3381a8e929494dc496528c
7 changes: 3 additions & 4 deletions packages/edit-site/src/components/dataviews-actions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,9 @@ export const useSetActiveTemplateAction = () => {
return false;
}

// If it's not a created template but a registered template
// (which means the source property is set), only allow
// activating (so when it's inactive).
if ( item.source ) {
// If it's not a created template but a registered template,
// only allow activating (so when it's inactive).
if ( typeof item.id !== 'number' ) {
return item._isActive === false;
}

Expand Down