-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Build v2: Fix build failure on Windows #72960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The cause is clear, and the fix is minor, so I'd like to merge this PR once the CI checks have passed. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
|
I'm one of the few Windows developers around, so I'd be happy to help if you need anything 😄 |
Thanks! I may take you up on that offer in #72946, at least for a review. I'm still trying to work through the issues there, but it's a bit of "guess and check" work without having a Windows setup 😅 |
What?
This PR fixes the Gutenberg build CI failures occurring in the
wordpress-developrepository.Example of a failed CI: https://github.com/WordPress/wordpress-develop/actions/runs/19058795688/job/54435503272
Why? How?
The
getAllPackages()function retrieves all packages using a regular expression pattern. However, on Windows, the path separator is a backslash, and theglobmethod will not work correctly as is.This is a common problem, and it can be solved by using
normalizePath.Testing Instructions
On a Windows host OS, check out this branch and run
npm run build. The build should succeed.