Skip to content

DataViews: open the filters from the column table consistently #72998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 6 commits into from
Nov 21, 2025
Merged

DataViews: open the filters from the column table consistently #72998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d4f957
Fix: Inconsistent behavior for add filters in DataViews
hbhalodia Nov 5, 2025
9ba8a9d
Add changelog entry
hbhalodia Nov 5, 2025
739be87
Merge branch 'trunk' into fix/issue-72986-dataviews
hbhalodia Nov 10, 2025
d3524e4
Update to use useRef instead of useState
hbhalodia Nov 10, 2025
600a862
Merge branch 'trunk' into fix/issue-72986-dataviews
hbhalodia Nov 18, 2025
e6489c1
GH-72986 Use setIsShowingFilter in column header with DataViews context
hbhalodia Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/dataviews/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
### Bug fixes

- Fix: ensure primary actions are not wrapped in the list layout. [#73333](https://github.com/WordPress/gutenberg/pull/73333)
- Fix: DataViews consistently opens filter section on clicking Add Filter via column header. [#72998](https://github.com/WordPress/gutenberg/pull/72998)

## 10.3.0 (2025-11-12)

Expand Down
6 changes: 5 additions & 1 deletion packages/dataviews/src/dataviews-layouts/table/column-header-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
Icon,
privateApis as componentsPrivateApis,
} from '@wordpress/components';
import { forwardRef, Children, Fragment } from '@wordpress/element';
import { forwardRef, Children, Fragment, useContext } from '@wordpress/element';

/**
* Internal dependencies
Expand All @@ -27,6 +27,7 @@ import type {
ViewPickerTable as ViewPickerTableType,
Operator,
} from '../../types';
import DataViewsContext from '../../components/dataviews-context';

const { Menu } = unlock( componentsPrivateApis );

Expand Down Expand Up @@ -72,6 +73,8 @@ const _HeaderMenu = forwardRef( function HeaderMenu< Item >(
let operators: Operator[] = [];
const field = fields.find( ( f ) => f.id === fieldId );

const { setIsShowingFilter } = useContext( DataViewsContext );

if ( ! field ) {
// No combined or regular field found.
return null;
Expand Down Expand Up @@ -168,6 +171,7 @@ const _HeaderMenu = forwardRef( function HeaderMenu< Item >(
prefix={ <Icon icon={ funnel } /> }
onClick={ () => {
setOpenedFilter( fieldId );
setIsShowingFilter( true );
onChangeView( {
...view,
page: 1,
Expand Down
Loading