-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Field API: add format to date field type
#72999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
07a59dc
Implement format for fields of type date
oandregal ecf8495
Rename format to displayFormat and make it an object
oandregal 035c948
Add weekStartsOn property
oandregal 70f44f9
Use day names instead of numbers for the API
oandregal 21df561
Add changelog entry
oandregal 19a0dec
Update README
oandregal 2845809
displayFormat is an empty object for non-date field types
oandregal 13e5f23
Rename displayFormat to format
oandregal 9ffb93a
Fix: pass a date object, not a string, to prevent momentlib from mess…
oandregal 1145dd0
Rename for clarity
oandregal b191428
weekStartsOn: address feedback
oandregal 484f3fe
Prioritize runtime safety and code maintanability over type hints
oandregal af2e618
Improve README
oandregal 14a756b
Improve readibility of format normalization
oandregal 988a195
Better types
oandregal ddae41b
Improve checks for weekStartsOn
oandregal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use day names instead of numbers for the API
- Loading branch information
commit 70f44f9de6b4b0bca308a65cb4e0c4b875148d4c
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * Converts a weekStartsOn string to a number (0-6). | ||
| * | ||
| * @param day - The day name ('sunday', 'monday', etc.) | ||
| * @return The corresponding number (0 for Sunday, 1 for Monday, etc.) | ||
| */ | ||
| export function weekStartsOnToNumber( | ||
| day: | ||
| | 'sunday' | ||
| | 'monday' | ||
| | 'tuesday' | ||
| | 'wednesday' | ||
| | 'thursday' | ||
| | 'friday' | ||
| | 'saturday' | ||
| ): 0 | 1 | 2 | 3 | 4 | 5 | 6 { | ||
| const mapping = { | ||
| sunday: 0, | ||
| monday: 1, | ||
| tuesday: 2, | ||
| wednesday: 3, | ||
| thursday: 4, | ||
| friday: 5, | ||
| saturday: 6, | ||
| } as const; | ||
|
|
||
| return mapping[ day ]; | ||
| } | ||
|
|
||
| /** | ||
| * Converts a weekStartsOn number (0-6) to a string. | ||
| * | ||
| * @param day - The day number (0 for Sunday, 1 for Monday, etc.) | ||
| * @return The corresponding day name ('sunday', 'monday', etc.) | ||
| */ | ||
| export function numberToWeekStartsOn( | ||
| day: 0 | 1 | 2 | 3 | 4 | 5 | 6 | ||
| ): | ||
| | 'sunday' | ||
| | 'monday' | ||
| | 'tuesday' | ||
| | 'wednesday' | ||
| | 'thursday' | ||
| | 'friday' | ||
| | 'saturday' { | ||
| const mapping = { | ||
| 0: 'sunday', | ||
| 1: 'monday', | ||
| 2: 'tuesday', | ||
| 3: 'wednesday', | ||
| 4: 'thursday', | ||
| 5: 'friday', | ||
| 6: 'saturday', | ||
| } as const; | ||
|
|
||
| return mapping[ day ]; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.