Skip to content

Fix divider appearance between Edit and Edit navigation buttons in top toolbar mode #73430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
getdave wants to merge 2 commits into from
Closed

Fix divider appearance between Edit and Edit navigation buttons in top toolbar mode #73430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
238eee2
Refactor template-part-navigation-edit-button to directory structure
getdave Nov 19, 2025
2f30502
Refactor divider styles: use variables and standardize approach
getdave Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions ...s/template-part-navigation-edit-button.js → ...late-part-navigation-edit-button/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@ import {
BlockControls,
store as blockEditorStore,
} from '@wordpress/block-editor';
import {
ToolbarButton,
ToolbarGroup,
__experimentalDivider as Divider,
} from '@wordpress/components';
import { ToolbarButton, ToolbarGroup } from '@wordpress/components';
import { useSelect, useDispatch } from '@wordpress/data';
import { store as interfaceStore } from '@wordpress/interface';

Expand Down Expand Up @@ -97,14 +93,7 @@ function TemplatePartNavigationEditButton( { clientId } ) {

return (
<BlockControls group="other">
<ToolbarGroup>
{ /*
* Add a vertical divider to visually separate the "Edit navigation"
* button from the template part's "Edit" button. Both buttons share
* the same toolbar group ("other"), so without this divider they
* would appear directly adjacent with no visual separation.
*/ }
<Divider orientation="vertical" marginEnd={ 3 } />
<ToolbarGroup className="wp-block-template-part__navigation-edit-button">
<ToolbarButton
label={ __( 'Edit navigation' ) }
onClick={ onEditNavigation }
Expand Down
32 changes: 32 additions & 0 deletions packages/editor/src/hooks/template-part-navigation-edit-button/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
@use "@wordpress/base-styles/colors" as *;
@use "@wordpress/base-styles/variables" as *;

.wp-block-template-part__navigation-edit-button.components-toolbar-group {
// Add a vertical divider before the button to visually separate it
// from the template part's "Edit" button.
&::before {
display: inline;
width: 0;
height: auto;
border-right: 1px solid currentColor;
margin-right: $grid-unit-15;
content: "";
}

// In top toolbar mode, match the divider styling used in the collapsible block toolbar.
.editor-collapsible-block-toolbar & {
position: relative;
margin-left: 0.75 * $grid-unit;
padding-right: 0;

&::before {
height: $grid-unit-30;
border-right: $border-width solid $gray-300;
top: $grid-unit-05;
position: absolute;
left: -$border-width;
right: auto;
}
}
}

1 change: 1 addition & 0 deletions packages/editor/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,4 @@
@use "./components/visual-editor/style.scss" as *;
@use "./dataviews/fields/content-preview/style.scss" as *;
@use "./hooks/push-changes-to-global-styles/style.scss" as *;
@use "./hooks/template-part-navigation-edit-button/style.scss" as *;
Loading