Add root components directory #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
3 tasks
youknowriad
reviewed
May 9, 2017
components/README.md
Outdated
Contributor
There was a problem hiding this comment.
I love this. Shared UI components inside WordPress. This makes me think we should showcase those.
youknowriad
reviewed
May 9, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I think there's a style regression in the inserter buttons. They look bigger (more padding maybe).
Otherwise, this is great.
Member
Author
|
Good catch @youknowriad . Looks like this was just a typo, fixed in 6f0f79d. |
youknowriad
approved these changes
May 9, 2017
aduth
force-pushed
the
add/components-directory
branch
from
6f0f79d to
2c168f5
Compare
This was referenced May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #716
This pull request expands upon the restructuring outlined in #716, creating a new common root
componentsdirectory containing components which have shown to be generic between blocks- and editor-specific components.Testing instructions:
Ensure the build completes, tests pass, and editor initializes and appears without regressions. Specifically observe that there are no regressions in displayed buttons, icon buttons, icons, and toolbar components.