ContentOnlyControls: Refactor ad hoc fields to use setValue instead of updateBlockAttributes #73680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f updateBlockAttributes
andrewserong
requested review from
aaronrobertshaw,
oandregal,
ramonjd,
talldan and
tellthemachines
andrewserong
added
the
[Type] Code Quality
andrewserong
added
the
[Feature] Patterns
|
Size Change: -75 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Dec 2, 2025
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Nice work @andrewserong 👍
This is testing as advertised for me.
✅ Replacing or clearing images works
✅ Adding links to images and buttons works
✅ Rich text updates function correctly
✅ Functionality is consistent between this branch and trunk
Screen.Recording.2025-12-02.at.3.09.03.pm.mp4
LGTM 🚢
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Nice, thanks for the quick review @aaronrobertshaw! 🙇 |
andrewserong
deleted the
update/content-only-editable-fields-refactor-to-on-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #73261
Follow up to:
One step of refactoring ad hoc ContentOnlyControls to better align with the Fields / DataForms API: don't pass in
updateBlockAttributesto the Edit component's config, and instead use thesetValuemethod to provide mapping, and defer to the DataForm to make theupdateBlockAttributescall.Why?
As raised in #73261, the current implementation doesn't conform to the Fields API and adds some not-quite-random-but-inappropriate values to the
configobject for the Edit component. Ideally, we want to get these ad hoc ContentOnlyControls (media, link, richtext) closer to a state where they could become canonical parts of the DataForm / controls APIs — or at the very least, they should be as close as possible to that structure.Note: this PR just looks at
updateBlockAttributes. There are other things to be refactored in separate PRs, e.g.clientIdwhich is a bit tangled up with how rich text currently works. My hope is to look into other refactors in follow-ups and keep these changes fairly small.How?
onChangecallback passed toDataFormas this is already handled insetValueonChangeto handle theupdateBlockAttributescallsupdateBlockAttributesfunction from being passed in to the Edit configbackgroundTesting Instructions
trunkScreenshots or screencast
The only visual change is that the Cover block's background control will be shown by default now, instead of there being an empty Cover block area: