-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add Navigation Overlay close block (behind experiment) #73724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
0874d3a
Initial block reg
getdave a3a2aaa
Use placeholder icon
getdave a41e5da
typographt styles
getdave 509ba4d
Use richtext
getdave 65c6620
Make desc more generic
getdave efd367b
Rename block with navigation namespace
getdave f0ced15
Update remaining references to old name
getdave f8da4fe
Use new icon supplied by design
getdave e66deed
Restrict insertion to only when editing a overlay template part
getdave 65367c3
Register server side
getdave dbe8322
Apply recommended identifier to Richtext
getdave 4f6867e
i18n of close text
getdave 82c78bc
Tweal function naming
getdave 8eacbee
Avoid wrapper to simplify
getdave e26bf85
Simplify as a result of skipping serialization
getdave 6728514
Remove anchor support
getdave e2db952
Correct since doc
getdave f46c64a
Fix blank file PHP
getdave 9ec0ffd
Try fix to lint error in save def
getdave 741539f
Only apply default aria label when text is not being controlled
getdave 3a6d9f0
Same aria lavel fix but for save
getdave 733ca79
Mark block experimental in metadata
getdave 7fe8323
Remove i18n from save def
getdave 3f80654
Refactor to ToolsPanel
getdave a66d451
Simplify RichText usage
getdave e10225a
Reinstate only allowing selected formats
getdave 75a34c7
Style button manually
getdave 48ab8c2
Add safeguard around direct usage of editor store
getdave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make desc more generic
- Loading branch information
commit 65c6620fd8fef63111fe4da8f7f8bcb5735490ca
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.