Block Editor: Remove block selection clearer handling from iframe #73753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
This was referenced Dec 4, 2025
|
Size Change: -56 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Dec 5, 2025
| const bodyRef = useMergeRefs( [ | ||
| useBubbleEvents( iframeDocument ), | ||
| contentRef, | ||
| clearerRef, |
Member
There was a problem hiding this comment.
This probably doesn't make a difference? Not sure why it's both added here and ExperimentalBlockCanvas. Maybe we should keep one, not sure why it was ever added to ExperimentalBlockCanvas.
Member
Author
There was a problem hiding this comment.
What do you mean by difference? The current removal fixes the mentioned.
I thought one in ExperimentalBlockCanvas was responsible for both iframed and non-iframed editors.
Member
There was a problem hiding this comment.
I'm curious why it fixes the issue if it's still added by ExperimentalBlockCanvas?
Member
Author
There was a problem hiding this comment.
The clearerRef( documentElement ); attaches events to the iframe document, which then react to clicks on the scrollbar.
The one from ExperimentalBlockCanvas is attached to the body and doesn't have the same problem. This was introduced as part of general framework improvements (#54209).
In my tests, removing the ref callback from this component fixes the bug without introducing any regressions.
Member
Author
There was a problem hiding this comment.
@ellatrix, let me know if there's a different path/solution you want me to pursue.
P.S. I tried deleting the click the scrollbar, but, to my understanding, it's almost impossible to do correctly across browsers and OS.
Member
There was a problem hiding this comment.
ExperimentalBlockCanvas adds the clearer as the contentRef, which is added to the same element through the line above this one. I don't get what the difference is? Is there a bug because it is added twice to the same element?
Member
There was a problem hiding this comment.
Ah, this one is also added to the body. So why remove it?
Member
Author
There was a problem hiding this comment.
I believe the problem is that the removed ref callback was attached to the html, which was causing the bug.
As far as I can tell, this doesn't introduce any regressions, so let's merge it.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Partially reverts #31385.
Closes #73547.
PR removes
useBlockSelectionClearerto avoid clearing block selection when clicking on the canvas scrollbar in the iframed editor. This matches the behavior of non-iframed editors.Why?
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-12-04.at.16.39.34.mp4