Skip to content

Block Supports: Extract reusable preset input control from spacing sizes and border radius controls #73787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 15 commits into from
Dec 11, 2025
Merged

Block Supports: Extract reusable preset input control from spacing sizes and border radius controls #73787

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
059f5a2
Fix docblock
aaronrobertshaw Nov 13, 2025
50135ce
Draft PresetInputControl
aaronrobertshaw Nov 13, 2025
1fb1212
Add unit tests for PrestInputControl utils
aaronrobertshaw Dec 5, 2025
02ffd5f
Fix old typo in CUSTOM_VALUE_SETTINGS
aaronrobertshaw Dec 5, 2025
755006c
Add tests for BorderRadiusControl prior to refactor
aaronrobertshaw Dec 5, 2025
d83d8e8
Refactor BorderRadiusControl to use PresetInputControl
aaronrobertshaw Dec 5, 2025
793b815
Add tests to SpacingSizesControl before refactor
aaronrobertshaw Dec 5, 2025
ab3b790
Refactor SpacingSizesControl to use new PresetInputControl
aaronrobertshaw Dec 5, 2025
f5e59fb
Clean up PresetInputControl styling
aaronrobertshaw Dec 8, 2025
4ac2499
Fix
aaronrobertshaw Dec 8, 2025
ce2932f
Add baseline tests for the PresetInputControl
aaronrobertshaw Dec 10, 2025
97de20d
Fix mutating prop in new PresetInputControl
aaronrobertshaw Dec 10, 2025
44e0b3a
Fix side effect during slider render phase
aaronrobertshaw Dec 10, 2025
f4e0acf
Refactor PresetInputControl to use CustomValueControl
aaronrobertshaw Dec 10, 2025
6679565
Fix e2e
aaronrobertshaw Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix mutating prop in new PresetInputControl
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Dec 10, 2025
commit 97de20dda3b34c5d36a6c1d088793bef058e5948
10 changes: 6 additions & 4 deletions packages/block-editor/src/components/preset-input-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
import { usePrevious } from '@wordpress/compose';
import { __, sprintf } from '@wordpress/i18n';
import { settings } from '@wordpress/icons';
import { useState } from '@wordpress/element';
import { useMemo, useState } from '@wordpress/element';

/**
* Internal dependencies
Expand Down Expand Up @@ -68,7 +68,7 @@ export default function PresetInputControl( {
disableCustomValues,
icon,
isMixed,
value,
value: valueProp,
minimumCustomValue,
onChange,
onMouseOut,
Expand All @@ -80,8 +80,10 @@ export default function PresetInputControl( {
showTooltip,
units,
} ) {
// Treat value as a preset value if the passed in value matches the value of one of the presets.
value = getPresetValueFromCustomValue( value, presets, presetType );
const value = useMemo(
() => getPresetValueFromCustomValue( valueProp, presets, presetType ),
[ valueProp, presets, presetType ]
);

const className = classNameProp ?? 'preset-input-control';

Expand Down