Prevent start page options modal from opening when navigating back from template parts #74037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The start page options modal was incorrectly opening when navigating to or back from empty template parts. This occurred because template parts were not excluded from the auto-open logic, which is intended only for pages. This fix adds wp_template_part to the exclusion list alongside wp_template, ensuring the modal only appears for appropriate post types.
getdave
force-pushed
the
fix/prevent-start-page-modal-on-template-parts
branch
from
c1f4f4e to
5e0437d
Compare
getdave
added
[Block] Template Part
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
getdave
changed the title
jeryj
approved these changes
Dec 16, 2025
Contributor
jeryj
left a comment
jeryj
left a comment
There was a problem hiding this comment.
Thanks for the PR! This fixes the issue of the start modal appearing when navigating backwards from a blank, new template part. I also tested that the modal appropriately appears when creating a new page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug where the start page options modal opens when navigating to or back from empty template parts. The modal should only appear for pages, not template parts.
This bug was uncovered as part of #73919.
Why
The start page options modal is intended for pages. When navigating back from an empty template part, the component treated it as a "fresh page" because it was empty and not dirty, causing the modal to open. Template parts should be excluded from this auto-open behavior, similar to how templates (
wp_template) are already excluded.How
Adds
TEMPLATE_PART_POST_TYPEto the exclusion list in theStartPageOptionscomponent, alongside the existingTEMPLATE_POST_TYPEexclusion. This prevents the modal from auto-opening when editing template parts.Testing Instructions
Screenshots
Before
Screen.Capture.on.2025-12-16.at.11-46-06.mp4
After
Screen.Capture.on.2025-12-16.at.11-47-35.mp4