Skip to content

Block support: Add anchor support for dynamic blocks #74183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 4 commits into from
Dec 25, 2025
Merged

Block support: Add anchor support for dynamic blocks #74183

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ade13f4
Block support: Add anchor support for dynamic blocks
t-hamano Dec 23, 2025
8826e69
Add backport changelog
t-hamano Dec 23, 2025
cabcbae
Update unit test and accept zero value
t-hamano Dec 24, 2025
17a3b1d
Fix lint error
t-hamano Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix lint error
  • Loading branch information
@t-hamano
t-hamano committed Dec 24, 2025
commit 17a3b1d6bece9734032c9dc29156251ad7d0cd61
20 changes: 10 additions & 10 deletions phpunit/block-supports/anchor-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function test_gutenberg_apply_anchor_support( $support, $value, $expected
*/
public function data_anchor_block_support() {
return array(
'anchor id attribute is applied' => array(
'anchor id attribute is applied' => array(
'support' => true,
'value' => 'my-anchor',
'expected' => array( 'id' => 'my-anchor' ),
Expand All @@ -80,12 +80,12 @@ public function data_anchor_block_support() {
'value' => 'my-anchor',
'expected' => array(),
),
'empty anchor value returns empty array' => array(
'empty anchor value returns empty array' => array(
'support' => true,
'value' => '',
'expected' => array(),
),
'null anchor value returns empty array' => array(
'null anchor value returns empty array' => array(
'support' => true,
'value' => null,
'expected' => array(),
Expand All @@ -95,37 +95,37 @@ public function data_anchor_block_support() {
'value' => ' ',
'expected' => array( 'id' => ' ' ),
),
'anchor with hyphen and numbers' => array(
'anchor with hyphen and numbers' => array(
'support' => true,
'value' => 'section-123',
'expected' => array( 'id' => 'section-123' ),
),
'anchor with underscore' => array(
'anchor with underscore' => array(
'support' => true,
'value' => 'my_anchor_id',
'expected' => array( 'id' => 'my_anchor_id' ),
),
'anchor with colon (valid in HTML5)' => array(
'anchor with colon (valid in HTML5)' => array(
'support' => true,
'value' => 'my:anchor',
'expected' => array( 'id' => 'my:anchor' ),
),
'anchor with period (valid in HTML5)' => array(
'anchor with period (valid in HTML5)' => array(
'support' => true,
'value' => 'my.anchor',
'expected' => array( 'id' => 'my.anchor' ),
),
'numeric anchor value' => array(
'numeric anchor value' => array(
'support' => true,
'value' => '123',
'expected' => array( 'id' => '123' ),
),
'zero string anchor value is applied' => array(
'zero string anchor value is applied' => array(
'support' => true,
'value' => '0',
'expected' => array( 'id' => '0' ),
),
'false value is treated as empty' => array(
'false value is treated as empty' => array(
'support' => true,
'value' => false,
'expected' => array(),
Expand Down
Loading