-
Notifications
You must be signed in to change notification settings - Fork 4.7k
MediaEdit: expanded view #74336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaEdit: expanded view #74336
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.13 kB (+0.04%) Total Size: 2.6 MB
ℹ️ View Unchanged
|
2c36176 to
b5941da
Compare
oandregal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as in the designs and API-wise is fine.
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: oandregal <[email protected]>
|
Nice work here! |
What?
Part of: #72614
This PR adds the
expandedview for MediaEdit component, mostly based on the designs shared in the linked issue.Design feedback
expandedversion, the placeholder is part of the grid.2columns. The styles exist there for displaying 3 columns based on container queries.Testing Instructions
featuredImageField) in site editor's quick edit works as before.FeaturedImagefield locally to this:allowedTypes, multiple and isExpandedprops.Expanded view with single file
single.mov
Expanded view with multiple files
multiple.mov