List View Panel: Fix circular dependency issue that was breaking some Storybook stories #74399
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Storybook stories
andrewserong
requested review from
ramonjd,
talldan,
tellthemachines and
youknowriad
andrewserong
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SirLouen
approved these changes
Jan 7, 2026
Member
SirLouen
left a comment
SirLouen
left a comment
There was a problem hiding this comment.
I can confirm it's blowing. Patch looking good ✅
|
Size Change: -86 B (0%) Total Size: 3.08 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Thanks for the quick review! 🙇 |
ciampo
pushed a commit
that referenced
this pull request
Jan 7, 2026
… Storybook stories (#74399) Co-authored-by: andrewserong <[email protected]> Co-authored-by: SirLouen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a regression introduced in #74120 that caused some Storybook stories to break (I noticed this in the the Fields and Media Fields stories).
Specifically, in the List View Panel, don't attempt to
unlockthePrivateListViewcomponent, but simply use it directly as we're already in the block editor package.Why?
Because we're already in the block editor package, we shouldn't be importing and unlocking the private api, since we're already in this package. This caused a circular dependency that was apparent in Storybook's dev mode (but not its build mode). This is the summary that Claude gave me:
"The PR added the packages/block-editor/src/hooks/list-view.js file which created the circular dependency by importing and unlocking privateApis at the module top-level. The issue became more apparent after the Storybook v9 upgrade (PR #74143) on December 31, 2025, which changed webpack's module resolution behavior in dev mode."
How?
Import the
PrivateListViewcomponent directly instead of attempting to unlock.Testing Instructions
Test that everything works correctly:
Insert a social icons block and add a few child blocks. Select the parent social icons block and the list view panel should be available (you could also check the Buttons/Button block):
Next up, run
npm run storybook:devlocally to boot up Storybook. Then navigate to the Fields stories, e.g. this one, and it should render without error: http://localhost:50240/?path=/story/fields-base-fields--data-views-previewScreenshots or screencast
Before
After