Hide Display section from Nav Inspector Controls if empty #74495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -16 B (0%) Total Size: 3.08 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Jan 9, 2026
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Nice work! Let's merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides the Display inspector section when it would be empty (overlay experiment enabled + no submenus) and removes unused
hasSubmenuIndicatorSettingprop. Part of the Overlay Experiment: #73084Why?
When the customizable navigation overlays experiment is enabled and a navigation block has no submenus, the Display section appears empty. This creates a poor UX.
The
hasSubmenuIndicatorSettingprop has been unused since the Navigation Editor experiment was removed in #47055 (Jan 2023). It was originally added in #25329 to allow the Navigation Editor to hide controls, but nothing sets it tofalseanymore.How?
Added condition to hide the Display section when overlay experiment is enabled AND there are no submenus. Removed the unused
hasSubmenuIndicatorSettingprop.Testing Instructions
Testing Instructions for Keyboard