-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Block Editor: The insertBlock(s) actions should receive the same arguments #75197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14
−6
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -517,11 +517,12 @@ export function moveBlockToPosition( | |||
| * Only allowed blocks are inserted. The action may fail silently for blocks that are not allowed or if | ||||
| * a templateLock is active on the block list. | ||||
| * | ||||
| * @param {Object} block Block object to insert. | ||||
| * @param {?number} index Index at which block should be inserted. | ||||
| * @param {?string} rootClientId Optional root client ID of block list on which to insert. | ||||
| * @param {?boolean} updateSelection If true block selection will be updated. If false, block selection will not change. Defaults to true. | ||||
| * @param {?Object} meta Optional Meta values to be passed to the action object. | ||||
| * @param {Object} block Block object to insert. | ||||
| * @param {?number} index Index at which block should be inserted. | ||||
| * @param {?string} rootClientId Optional root client ID of block list on which to insert. | ||||
| * @param {?boolean} updateSelection If true block selection will be updated. If false, block selection will not change. Defaults to true. | ||||
| * @param {0|-1|null} initialPosition Initial focus position. Setting it to null prevent focusing the inserted block. | ||||
| * @param {?Object} meta Optional Meta values to be passed to the action object. | ||||
| * | ||||
| * @return {Object} Action object. | ||||
| */ | ||||
|
|
@@ -530,14 +531,15 @@ export function insertBlock( | |||
| index, | ||||
| rootClientId, | ||||
| updateSelection, | ||||
| initialPosition, | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like we don't have existing usages of the fifth argument, except one here:
It's in RN code, but still, perhaps makes sense to update it to |
||||
| meta | ||||
| ) { | ||||
| return insertBlocks( | ||||
| [ block ], | ||||
| index, | ||||
| rootClientId, | ||||
| updateSelection, | ||||
| 0, | ||||
| initialPosition, | ||||
| meta | ||||
| ); | ||||
| } | ||||
|
|
||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.