Skip to content

Add tweet block for embedding tweets #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notnownikki wants to merge 13 commits into from
Closed

Add tweet block for embedding tweets #754

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3cd38d1
Tweet block - WORK IN PROGESS! Don't merge or review or anything.
notnownikki May 10, 2017
abc74cd
Tweet block - WORK IN PROGESS! Don't merge or review or anything.
notnownikki May 10, 2017
5fa3cb8
Polish placeholder error message.
jasmussen May 10, 2017
8c38062
Merge branch 'add/twitter-block' of github.com:WordPress/gutenberg in…
jasmussen May 10, 2017
09814e5
Merge latest changes.
jasmussen May 10, 2017
eedb7d7
Tweet block
notnownikki May 10, 2017
ce8fc70
Fixes from code review
notnownikki May 11, 2017
5fd1bb9
Lint fixes
notnownikki May 11, 2017
0aad93d
Add jQuery
notnownikki May 11, 2017
5ce13f6
i18n fix for sandboxed iframe titles
notnownikki May 11, 2017
a43001f
Merge branch 'master' into add/twitter-block
notnownikki May 11, 2017
c223f18
Fixed iframe title after some a11y discussions
notnownikki May 11, 2017
ff12c83
Merge branch 'add/twitter-block' of github.com:WordPress/gutenberg in…
notnownikki May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed iframe title after some a11y discussions
  • Loading branch information
@notnownikki
notnownikki committed May 11, 2017
commit c223f18571e413c6de2e13eb9cd88105b63a9b5f
5 changes: 2 additions & 3 deletions blocks/library/tweet/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ registerBlock( 'core/tweet', {
const { html, url, error, fetching } = this.state;

if ( html ) {
const author = this.state.url.split( '/' )[ 3 ];
/* translators: %s: username of the tweet's author */
const title = wp.i18n.sprintf( wp.i18n.__( 'Tweet from %s' ), author );
/* translators: %s: url of the tweet */
const title = wp.i18n.sprintf( wp.i18n.__( 'Embedded from %s' ), url );
return (
<Sandbox
html={ html }
Expand Down