Skip to content

Conversation

@gziolo
Copy link
Member

@gziolo gziolo commented Jul 9, 2018

Description

2nd try to merge https://github.com/WordPress/packages into Gutenberg. This time hopefully with history preserved, in contrast to #7556 :)

adamsilverstein and others added 30 commits September 12, 2017 08:42
Add the WordPress hook library from 21170-core in preparation for beta npm release
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
…-hooks

Correctly enable dashes in regexes in validateNamespace
Questionable value of the test assertions, which are specific to the implementation and not the expected intent of the test case
# Conflicts:
#	packages/hooks/src/test/index.test.js
#	packages/hooks/src/validateNamespace.js
@gziolo gziolo added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Build Tooling Issues or PRs related to build tooling npm Packages Related to npm packages labels Jul 9, 2018
@gziolo gziolo added this to the 3.3 milestone Jul 9, 2018
@gziolo gziolo self-assigned this Jul 9, 2018
@gziolo gziolo requested review from ntwb and omarreiss July 9, 2018 08:21
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit:

@gziolo gziolo merged commit 921e9d8 into master Jul 9, 2018
@gziolo gziolo deleted the add-packages branch July 9, 2018 08:52
ntwb pushed a commit that referenced this pull request Jul 10, 2018
This pull request seeks to update `package.json` to apply correct alphabetical ordering to `devDependencies`. This change was observed with a simple `npm install`, likely related to the merge of packages in #7805.

**Testing instructions:**

Ensure npm installs without issue:

```
npm install
```

Should be no impact on the application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript npm Packages Related to npm packages [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.