Align timepicker to calendar #7864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
approved these changes
Jul 19, 2018
Member
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
Works for me, just a note about using a variable if that width is related to anything else.
| align-items: center; | ||
| justify-content: center; | ||
| margin-top: 10px; | ||
| max-width: 248px; |
Member
There was a problem hiding this comment.
Why was this size picked? Is it the max-width of the datepicker itself? If so, we should use a variable.
Member
Author
There was a problem hiding this comment.
It's just a (manually calculated) width of the calendar itself, which doesn't seem to change at all. The number isn't used elsewhere, so whilst we could add a variable for it, I'm not sure we'd ever need/want to use it elsewhere.
Member
There was a problem hiding this comment.
Makes sense; a comment explaining that would be great, in that case.
sarahmonster
force-pushed
the
update/calendar-alignment
branch
from
db1bbc5 to
0cc23c8
Compare
gziolo
added
the
[Feature] UI Components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At tablet-ish screen sizes, the calendar in the pre-publish panel is aligned to the left of the panel, whilst the timepicker attached to it floats way out in the middle of the screen, making them seem disconnected. Adding a max-width to the timepicker solves this issue and doesn't seem to break when using different languages, zoom levels, or font sizes.
Fixes #7863.
How has this been tested?
Tested in Chrome/Firefox on a Mac, in English, Hebrew, and Japanese (and at varying levels of zoom and font sizes).
Before:
After:
Types of changes
Simple bug fix.
Checklist: