Skip to content

Enhance the embed block to support all WP_oEmbed embeds #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notnownikki merged 16 commits into from
Jun 2, 2017
Merged

Enhance the embed block to support all WP_oEmbed embeds #816

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f9d17bc
Updated the embed block to use the oembed proxy API
notnownikki May 31, 2017
2723e86
Lint fixes
notnownikki May 31, 2017
d071080
Fix tests
notnownikki May 31, 2017
6fea1e8
Fix initial render of the embed block when loading a saved post
notnownikki May 31, 2017
830b743
Polish the embed placeholder a bit.
jasmussen Jun 1, 2017
b99e42c
Fix video and "other" ambiguation.
jasmussen Jun 1, 2017
c55973f
Address a couple of PR review items
jasmussen Jun 1, 2017
540c43c
Fixed components import
notnownikki Jun 1, 2017
42172c0
Adds wpApiSettings to the globals in .eslintrc.json
notnownikki Jun 1, 2017
ea6ff87
Deal with the component unmounting while a fetch is ongoing
notnownikki Jun 1, 2017
19f8477
Comment explaining the purpose of HtmlEmbed component
notnownikki Jun 1, 2017
f09a47f
Remove default prop in HtmlEmbed
notnownikki Jun 1, 2017
a235861
New script element creation tidied up
notnownikki Jun 1, 2017
d934958
Lint fix
notnownikki Jun 1, 2017
316fb7d
Fix typo
notnownikki Jun 1, 2017
58acca1
Fixed comment style
notnownikki Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix initial render of the embed block when loading a saved post
  • Loading branch information
@notnownikki
notnownikki committed Jun 1, 2017
commit 6fea1e8e6976c94b3d78caf20b618b3b8795e102
8 changes: 7 additions & 1 deletion blocks/library/embed/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,16 @@ registerBlock( 'core/embed', {
this.noPreview = [
'facebook.com',
];
if ( this.props.attributes.url ) {
// if the url is already there, we're loading a saved block, so we need to render
this.doServerSideRender();
}
}

doServerSideRender( event ) {
Copy link
Contributor

@youknowriad youknowriad May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we extract this ServerSideRender to a HoC? Maybe something like:

<ServerSideBlock blockType={ blockType } arguments={ arguments }>
  { ( html, error ) => (
    <Sandbox html={ html } /> 
  ) }
</ServerSideBlock>

Any blocker to achieve this?

Copy link
Member Author

@notnownikki notnownikki May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only blocker is I need to read more React docs to figure out how to do it. There were async issues with having Sandbox as the containing block, this seems like a much better way, I've just never done it before.

Copy link
Contributor

@youknowriad youknowriad May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this post could help https://medium.com/merrickchristensen/function-as-child-components-5f3920a9ace9

event.preventDefault();
if ( event ) {
event.preventDefault();
}
const { url } = this.props.attributes;
const api_url = wpApiSettings.root + 'oembed/1.0/proxy?url=' + encodeURIComponent( url ) + '&_wpnonce=' + wpApiSettings.nonce; // eslint-disable-line no-undef

Expand Down