Skip to content

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented May 17, 2017

See #516.

@ellatrix
Copy link
Member Author

This block is meant for preformatted text, not code. Feel free to change or remove the content added.

@ellatrix ellatrix requested a review from jasmussen May 17, 2017 16:08
@mtias mtias added the [Feature] Blocks Overall functionality of blocks label May 17, 2017
@ellatrix
Copy link
Member Author

See #826 for code block.

@jasmussen
Copy link
Contributor

Nice!

I think we should zero out the margin on the pre. The margin will then be implied by the block padding instead. Otherwise works exactly as I would have expected. Very cool!

@jasmussen
Copy link
Contributor

Did some polish here.

One thing is missing from the stylesheet, and that's the new code font size variable that I introduced for the code block in 215881c. So once we have both merged, we should add font-size: $text-editor-font-size; to this pre block.

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts, but otherwise looks good 👍

@ellatrix ellatrix force-pushed the add/preformatted-block branch from 7648f2d to 0cb5489 Compare May 18, 2017 15:40
@ellatrix ellatrix merged commit 258f24f into master May 18, 2017
@ellatrix ellatrix deleted the add/preformatted-block branch May 18, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Blocks Overall functionality of blocks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants