Remove oEmbed fixture files #8393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Automated Testing
Member
|
+100 |
tofumatt
approved these changes
Aug 2, 2018
Member
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
Makes sense to me, I don't think they're useful tests looking at this diff now.
notnownikki
approved these changes
Aug 2, 2018
Member
notnownikki
left a comment
notnownikki
left a comment
There was a problem hiding this comment.
This is my favourite PR of the week.
Contributor
|
This thread: 🏆 |
Member
Author
|
Cool, that didn't need much convincing! :) |
Member
|
Noice 💐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't think these are that useful to have because all of them have the same
savefunctions and attributes as the embed block. They bloat PRs (such as #7890) that change the embed block, and it's a waste of time to update them all.