Fix unrecognised forwardedRef prop
#8570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Code Quality
nerrad
reviewed
Aug 6, 2018
Contributor
nerrad
left a comment
nerrad
left a comment
There was a problem hiding this comment.
I think it might be better to remove the forwardedRef prop on any leaf components rather than in the HOC.
aduth
requested changes
Aug 6, 2018
| return <WrappedComponent { ...this.props } ref={ this.handleRef } />; | ||
| return ( | ||
| <WrappedComponent | ||
| { ...omit( this.props, [ 'forwardedRef' ] ) } |
Member
There was a problem hiding this comment.
Performance-wise, we could probably benefit by just passing the original props as a standalone prop value from within forwardRef, rather than iterating the props object to remove forwardedRef on every render.
return forwardRef( ( props, ref ) => {
return <Wrapper ownProps={ props } forwardedRef={ ref } />;
} );For example, we do this with withSelect:
Member
Author
There was a problem hiding this comment.
Good suggestion! I've updated the PR.
Member
How would this be implemented? |
Contributor
Your suggestion here: #8570 (review) would make my suggestion moot :). |
noisysocks
force-pushed
the
fix/unrecognised-forwardedRef-prop
branch
from
9078205 to
d9b7032
Compare
Have `withGlobalEvents` omit the `forwardedRef` prop. This prevents the prop being added to HTML in some cases, e.g. when used in `FocusableIframe`.
noisysocks
force-pushed
the
fix/unrecognised-forwardedRef-prop
branch
from
d9b7032 to
13dcbda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a warning I noticed while testing #8556.
withGlobalEventswas settingforwardedRefon the wrapped component, which caused anUnrecognised forwardedRef propReact warning inFocusableIframe.Also corrects some incorrect indentation in some embedded JavaScript.
How has this been tested?
Custom HTMLblockPreviewbuttonNo errors or warnings should appear in the console.