Packages: Redux Routine: Add Babel runtime dependency #8660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
fix/redux-routine-babel-runtime
branch
from
432f41e to
08f1fbe
Compare
gziolo
force-pushed
the
fix/redux-routine-babel-runtime
branch
from
08f1fbe to
80de958
Compare
gziolo
approved these changes
Aug 8, 2018
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Should be good after all fixes applied, in particular, all oddities with package-lock.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8096 (comment)
This pull request seeks to add
@babel/runtimeas a dependency of the@wordpress/redux-routinepackage, since its transpiled output includes a module dependency on this package.This may need to be reconciled with updates to use fixed version dependency proposed in #8586.
Testing instructions:
Verify
npm install