Skip to content

Publishes unknown-type handler methods for mobile. #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diegoreymendez merged 3 commits into from
Aug 9, 2018
Merged

Publishes unknown-type handler methods for mobile. #8688

diegoreymendez merged 3 commits into from
Aug 9, 2018

Conversation

@diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Aug 7, 2018 •
edited
Loading

Description

This PR exports the block-API unknown-type handler getter and setter for mobile. This is a change that brings us toward standardizing the block API between mobile and web.

How has this been tested?

Tested in as a submodule in gutenberg-mobile.

Types of changes

This PR simply exports the block-API methods setUnknownTypeHandlerName and getUnknownTypeHandlerName.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@diegoreymendez diegoreymendez self-assigned this Aug 7, 2018
@diegoreymendez diegoreymendez added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Feature] Block API API that allows to express the block paradigm. labels Aug 7, 2018
@diegoreymendez
Copy link
Contributor Author

diegoreymendez commented Aug 8, 2018 •
edited
Loading

Just a note about the failing tests: they're also present in master and were not introduced by this PR.

Reference: #8588 (comment)

mzorz
mzorz approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 LGTM :shipit:

@diegoreymendez diegoreymendez merged commit 4f0a643 into master Aug 9, 2018
@diegoreymendez diegoreymendez deleted the update/mobile-add-unknown-block-type-exports branch August 9, 2018 13:08
@diegoreymendez
Copy link
Contributor Author

diegoreymendez commented Aug 9, 2018

Merged, since I need to move forward, and have an approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzorz mzorz mzorz approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees

@diegoreymendez diegoreymendez

Labels

[Feature] Block API API that allows to express the block paradigm. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diegoreymendez @mzorz