Skip to content

Inserter: update categories and height #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtias merged 2 commits into from
May 23, 2017
Merged

Inserter: update categories and height #872

mtias merged 2 commits into from
May 23, 2017

Conversation

@mtias
Copy link
Member

@mtias mtias commented May 23, 2017

image

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels May 23, 2017
@mtias mtias merged commit 38427b6 into master May 23, 2017
@mtias mtias deleted the update/block-categories-inserter branch May 23, 2017 12:54
aduth
aduth reviewed May 23, 2017
View reviewed changes
editor/inserter/style.scss

.editor-inserter__content {
max-height: 186px;
max-height: 20vw;
Copy link
Member

@aduth aduth May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be vh, not vw?

Copy link
Member Author

@mtias mtias May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
@soloinovator soloinovator mentioned this pull request Apr 25, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth aduth left review comments

Assignees

No one assigned

Labels

[Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtias @aduth