Skip to content

Show toolbar on meta key press #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellatrix wants to merge 2 commits into from
Closed

Show toolbar on meta key press #873

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ca482
Show toolbar on meta key press
ellatrix May 23, 2017
a80502f
Ignore toolbars in focus order
ellatrix May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ignore toolbars in focus order
  • Loading branch information
@ellatrix
ellatrix committed May 23, 2017
commit a80502f42e6c54f7754a1cb41a4b6f8d70e1dda8
2 changes: 1 addition & 1 deletion editor/block-mover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function BlockMover( { onMoveUp, onMoveDown, isFirst, isLast } ) {
// the rendering parent, leaving it unable to react to focus out.

return (
<div className="editor-block-mover">
<div className="editor-block-mover" tabIndex="-1">
<IconButton
className="editor-block-mover__control"
onClick={ isFirst ? null : onMoveUp }
Expand Down
3 changes: 1 addition & 2 deletions editor/modes/visual-editor/block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,11 @@ class VisualEditorBlock extends wp.element.Component {
onMouseLeave={ onMouseLeave }
className={ className }
data-type={ block.blockType }
tabIndex="0"
{ ...wrapperProps }
>
{ ( showUI || isHovered ) && <BlockMover uid={ block.uid } /> }
{ showUI &&
<div className="editor-visual-editor__block-controls">
<div className="editor-visual-editor__block-controls" tabIndex="-1">
<BlockSwitcher uid={ block.uid } />
{ !! settings.controls && (
<Toolbar
Expand Down