Skip to content

Conversation

@ellatrix
Copy link
Member

So trigger the callback on keyup as well.

Testing this a bit more and looking at browser bug reports. It's strange that the event does not fire, because the selection does change...

@youknowriad
Copy link
Contributor

Quick testing: It seems to work as expected. I've not noticed any regression. I tried mergin/splitting, backspacing in the middle of text. Is this a TinyMCE bug?

@ellatrix
Copy link
Member Author

No, selectionChange is a browser event. In Firefox this seems to work fine.

@ellatrix
Copy link
Member Author

I only see it misbehave in Chrome: https://codepen.io/iseulde/pen/LyqXMx

@youknowriad
Copy link
Contributor

@iseulde your codepen works for me in Chrome too "Version 57.0.2987.133 (64-bit) MacOS"

@ellatrix
Copy link
Member Author

Really? I'm at Version 58.0.3029.110 (64-bit) and up-to-date.

@youknowriad
Copy link
Contributor

hahahah it's broken now after an upgrade to v58

@ellatrix
Copy link
Member Author

:) I'll write a bug report then.

@ellatrix
Copy link
Member Author

Didn't seem to be reported, so: https://bugs.chromium.org/p/chromium/issues/detail?id=725890
Maybe we should just wait for this then.

@ellatrix
Copy link
Member Author

@youknowriad Did you notice any other placeholder bugs? I thought I remembered you raising an issue, but it clearly was not this one then. :)

@youknowriad
Copy link
Contributor

Actually, this branch fixes the issue I was having when clearing the quote citation field.

@ellatrix
Copy link
Member Author

Alright, let's revisit when it's fixed in Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants