Apply new checkbox CSS to radio buttons and fix border radius #8835
Conversation
|
I can't request my own reviews (insert sadface here) so pinging @jasmussen :) |
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Love it. Great catch, and thanks for doing this. Huge improvement to the selected state. Thanks. Left one comment, otherwise good to go after that.
| } | ||
|
|
||
| input[type="radio"] { | ||
| border-radius: 50%; |
There was a problem hiding this comment.
Can you use $radius-round here, from https://github.com/WordPress/gutenberg/blob/master/edit-post/assets/stylesheets/_variables.scss?
|
@jasmussen Had no idea that variable existed and I was literally just looking at the variable file. No idea how I missed it. Anyway, I updated that and it should be ready to 🚢 ! |
|
(Travis failure looks unrelated… couldn't find |
|
Travis is acting up these days. I'll try and restart the job until it passes, thanks again. |
|
I can't get Travis to pass. I've tried restarting three times now. It's not your fault, and we'll get this in for the next release, I've put it in the milestone, but I think we'll need to do a staredown with Travis. |
|
@jasmussen No worries, I know Travis is being grumpy today! Maybe he is taking a long weekend? |
|
@jasmussen Is this good to merge now that Travis is happy? |
|
Yes, thank you! |
2 participants
Description
This PR applies the new checkbox styles from #8588 to radio buttons, and fixes a regression with the radio input border-radius caused by #8385.
Fixes #8833.
How has this been tested?
Visual testing
Screenshots
Before:
After:
Types of changes
Visual, non-breaking CSS changes
Checklist: