Skip to content

toAsyncIterable: remove Promise.resolve call that's already done by the JS runtime #8913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Aug 15, 2018
Merged

toAsyncIterable: remove Promise.resolve call that's already done by the JS runtime #8913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/data/src/registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,8 @@ export function toAsyncIterable( object ) {
object = [ object ];
Copy link
Member

@aduth aduth Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: The comment preceding the condition reads as a continuation which was previously continued as "...of Promises", now removed. This could be rewritten as a plain "Normalize as iterable"

}

for ( let maybeAction of object ) {
// ...of Promises.
if ( ! ( maybeAction instanceof Promise ) ) {
maybeAction = Promise.resolve( maybeAction );
}

yield await maybeAction;
for ( const maybeAction of object ) {
yield maybeAction;
}
}() );
}
Expand Down