Copy guidelines formatting tweaks #8952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made some formatting consistency tweaks to @michelleweber's fine work and added some bold emphasis that I believe was supposed to be there in the original PR. Props also to @karmatosed.
Contributor
Author
|
It's been pointed out to me that perhaps using the quote markdown is not technically correct for all the example text. My intention was to delineate them more because I found it hard to parse particularly in the section about bulleted lists. The lists themselves stood out, but the intro text before the list (which was also part of each example) blended right into the guidelines themselves. Is there a better strategy to clarify without using quote markdown? |
danielbachhuber
added
the
Needs Copy Review
chrisvanpatten
added
the
[Type] Developer Documentation
This was referenced Nov 8, 2018
tofumatt
approved these changes
Nov 12, 2018
Member
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
These improvements are solid and I think the quotes make everything more readable, so I'm for them. I'm going to merge this because it's an improvement; sorry it took ages to get to 😓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some formatting consistency tweaks to @michelleweber's fine work (from #7588) and added some bold emphasis that I believe was supposed to be there in the original PR. Props also to @karmatosed.