Skip to content

Framework: Remove deprecations slated for 3.6 removal#8993

Merged
aduth merged 2 commits intomasterfrom
remove/3-6-deprecations
Aug 16, 2018
Merged

Framework: Remove deprecations slated for 3.6 removal#8993
aduth merged 2 commits intomasterfrom
remove/3-6-deprecations

Conversation

@aduth
Copy link
Member

@aduth aduth commented Aug 14, 2018

This PR removes deprecations scheduled to be removed in the upcoming 3.6.0 release.

  • wp.editor.editorMediaUpload has been removed. Please use wp.editor.mediaUpload instead.
  • wp.utils.getMimeTypesArray has been removed.
  • wp.utils.mediaUpload has been removed. Please use wp.editor.mediaUpload instead.
  • wp.utils.preloadImage has been removed.
  • supports.wideAlign has been removed from the Block API. Please use supports.alignWide instead.
  • wp.blocks.isSharedBlock has been removed. Use wp.blocks.isReusableBlock instead.
  • fetchSharedBlocks action (core/editor) has been removed. Use fetchReusableBlocks instead.
  • receiveSharedBlocks action (core/editor) has been removed. Use receiveReusableBlocks instead.
  • saveSharedBlock action (core/editor) has been removed. Use saveReusableBlock instead.
  • deleteSharedBlock action (core/editor) has been removed. Use deleteReusableBlock instead.
  • updateSharedBlockTitle action (core/editor) has been removed. Use updateReusableBlockTitle instead.
  • convertBlockToSaved action (core/editor) has been removed. Use convertBlockToReusable instead.
  • getSharedBlock selector (core/editor) has been removed. Use getReusableBlock instead.
  • isSavingSharedBlock selector (core/editor) has been removed. Use isSavingReusableBlock instead.
  • isFetchingSharedBlock selector (core/editor) has been removed. Use isFetchingReusableBlock instead.
  • getSharedBlocks selector (core/editor) has been removed. Use getReusableBlocks instead.

Source: https://wordpress.org/gutenberg/handbook/reference/deprecated/#3-6-0

@aduth aduth added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Breaking Change For PRs that introduce a change that will break existing functionality labels Aug 14, 2018
@aduth aduth added this to the 3.6 milestone Aug 14, 2018
@aduth
Copy link
Member Author

aduth commented Aug 14, 2018

cc @gziolo I employed new CHANGELOG workflows proposed in #8768 and it feels quite effective, also helps shine light on the impact of breaking changes on versioning.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did quick check and this proposal for updates to the changelog files is awesome. This would definitely make publishing much easier if we could make it a part of the workflow. We might want to group changes by type, I explained it in more detailed way in docs changes PR.

@@ -0,0 +1,14 @@
## 3.0.0 (Unreleased)

- Breaking: The `wideAlign` block supports hook has been removed. Use `alignWide` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it also be included in blocks? Sometimes those changes touch more than one package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I agree it's relevant for someone implementing a block (interfacing with blocks), but the logic itself lives in editor, and as part of a general workflow I'd be conscious of removing the "make me think" part involved with considering documenting cascading effects.

Which is all to say: I don't think we should include it in blocks.

@aduth aduth force-pushed the remove/3-6-deprecations branch from d4a3100 to a791174 Compare August 16, 2018 15:49
@aduth aduth merged commit 63f0cf2 into master Aug 16, 2018
@aduth aduth deleted the remove/3-6-deprecations branch August 16, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Breaking Change For PRs that introduce a change that will break existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants