Skip to content

Conversation

@aduth
Copy link
Member

@aduth aduth commented May 26, 2017

See #907 (comment)

This pull request resolves an issue where the state.saving.isNew value is inaccurate after a post is saved successfully.

Testing instructions:

Repeat instructions from #907 (comment)

Ensure unit tests pass:

npm test

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label May 26, 2017
@aduth aduth requested a review from nylen May 26, 2017 22:43
@nylen
Copy link
Member

nylen commented May 27, 2017

Missed a spot: https://github.com/WordPress/gutenberg/pull/907/files#diff-aad59fa5eb910a7034e7a3cd9b491895L66

As far as the user experience, this controls the brief flash of text that appears when a save request is in progress. Prior to this PR it will say "Updating..." even for a new post; fixed in 2fec04e.

@nylen
Copy link
Member

nylen commented May 27, 2017

As a separate task, I think the confusion here indicates that this part of the state tree should be restructured a bit.

@aduth aduth force-pushed the fix/state-is-new branch from 2fec04e to b8950d1 Compare May 31, 2017 20:14
@aduth
Copy link
Member Author

aduth commented May 31, 2017

Thanks @nylen for noticing, explaining, and fixing 👍 Will merge shortly.

@nylen
Copy link
Member

nylen commented May 31, 2017

@aduth, sorry, I meant to say something sooner, but #945 removes this part of the state tree entirely. So this PR may not be needed anymore.

@aduth
Copy link
Member Author

aduth commented May 31, 2017

My fault for being slow on revisiting my own pull requests. I'll plan to catch up with the activity there.

@aduth
Copy link
Member Author

aduth commented Jun 2, 2017

Closing in favor of #945

@aduth aduth closed this Jun 2, 2017
@aduth aduth deleted the fix/state-is-new branch June 2, 2017 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants