Skip to content

Plugin: Drop Array.prototype.find calls and replace with lodash #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 1 commit into from
May 30, 2017
Merged

Plugin: Drop Array.prototype.find calls and replace with lodash #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions blocks/api/factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* External dependencies
*/
import uuid from 'uuid/v4';
import { get, castArray, findIndex, isObjectLike } from 'lodash';
import { get, castArray, findIndex, isObjectLike, find } from 'lodash';

/**
* Internal dependencies
Expand Down Expand Up @@ -49,8 +49,8 @@ export function switchToBlockType( block, blockType ) {
const transformationsFrom = get( destinationSettings, 'transforms.from', [] );
const transformationsTo = get( sourceSettings, 'transforms.to', [] );
const transformation =
transformationsTo.find( t => t.blocks.indexOf( blockType ) !== -1 ) ||
transformationsFrom.find( t => t.blocks.indexOf( block.blockType ) !== -1 );
find( transformationsTo, t => t.blocks.indexOf( blockType ) !== -1 ) ||
find( transformationsFrom, t => t.blocks.indexOf( block.blockType ) !== -1 );

// If no valid transformation, stop. (How did we get here?)
if ( ! transformation ) {
Expand Down
4 changes: 2 additions & 2 deletions blocks/editable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* External dependencies
*/
import classnames from 'classnames';
import { last, isEqual, capitalize, omitBy, forEach, merge, identity } from 'lodash';
import { last, isEqual, capitalize, omitBy, forEach, merge, identity, find } from 'lodash';
import { nodeListToReact } from 'dom-react';
import { Fill } from 'react-slot-fill';
import 'element-closest';
Expand Down Expand Up @@ -289,7 +289,7 @@ export default class Editable extends wp.element.Component {

onNodeChange( { element, parents } ) {
const formats = {};
const link = parents.find( ( node ) => node.nodeName.toLowerCase() === 'a' );
const link = find( parents, ( node ) => node.nodeName.toLowerCase() === 'a' );
if ( link ) {
formats.link = { value: link.getAttribute( 'href' ), link };
}
Expand Down
4 changes: 2 additions & 2 deletions editor/block-switcher/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* External dependencies
*/
import { connect } from 'react-redux';
import { uniq, get, reduce } from 'lodash';
import { uniq, get, reduce, find } from 'lodash';
import clickOutside from 'react-click-outside';

/**
Expand Down Expand Up @@ -54,7 +54,7 @@ class BlockSwitcher extends wp.element.Component {
const blockSettings = wp.blocks.getBlockSettings( this.props.block.blockType );
const blocksToBeTransformedFrom = reduce( wp.blocks.getBlocks(), ( memo, block ) => {
const transformFrom = get( block, 'transforms.from', [] );
const transformation = transformFrom.find( t => t.blocks.indexOf( this.props.block.blockType ) !== -1 );
const transformation = find( transformFrom, t => t.blocks.indexOf( this.props.block.blockType ) !== -1 );
return transformation ? memo.concat( [ block.slug ] ) : memo;
}, [] );
const blocksToBeTransformedTo = get( blockSettings, 'transforms.to', [] )
Expand Down