Skip to content

De-duplicate Webpack build, especially components/ #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nylen merged 10 commits into from
May 30, 2017
Merged

De-duplicate Webpack build, especially components/ #929

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
228442a
Build `components/` directory separately
nylen May 29, 2017
d151f3e
Fix the build
nylen May 29, 2017
ebb69e5
Enqueue wp.components script
nylen May 30, 2017
463a2be
Consolidate entry points into one variable
nylen May 30, 2017
63b2db4
Register all `wp.` libraries as Webpack externals
nylen May 30, 2017
e768d79
Restructure imports to top-level entry points only
nylen May 30, 2017
a47cf55
Fix duplicate imports
nylen May 30, 2017
3ba82c4
Fix naming of `withFocusReturn` HoC
nylen May 30, 2017
8cac43e
Fix the tests
nylen May 30, 2017
81a4bf4
Fix `wp-components` stylesheet and dependencies on editor page
nylen May 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the tests 
- Fix entry point order to match actual dependencies
- Fix externals (`wp.*` externals not needed)
  • Loading branch information
@nylen
nylen committed May 30, 2017
commit 8cac43e660218da0512ba1161874f9b1a723bf32
13 changes: 5 additions & 8 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ const webpack = require( 'webpack' );
const ExtractTextPlugin = require( 'extract-text-webpack-plugin' );

const entryPointNames = [
'blocks',
'components',
'date',
'editor',
'element',
'date',
'i18n',
'components',
'blocks',
'editor',
];

const externals = {
Expand Down Expand Up @@ -132,10 +132,7 @@ switch ( process.env.NODE_ENV ) {
...testFiles.filter( f => /full-content\.js$/.test( f ) ),
...testFiles.filter( f => ! /full-content\.js$/.test( f ) ),
];
config.externals = [
...config.externals,
require( 'webpack-node-externals' )(),
];
config.externals = [ require( 'webpack-node-externals' )() ];
config.output = {
filename: 'build/test.js',
path: __dirname,
Expand Down