Skip to content

Make the withNotices notices announced by assistive technologies #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afercia wants to merge 7 commits into from
Closed

Make the withNotices notices announced by assistive technologies #9443

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7d77a7
Add role alert to the withNotices notices.
afercia Aug 29, 2018
c3dc092
Always wrap notices in their wrapper.
afercia Aug 30, 2018
20b28e4
Restore the dismiss notice button tooltip.
afercia Aug 30, 2018
51adbbd
Update notice readme.
afercia Aug 30, 2018
c2a9c0f
Remove contrast checker notice wrapper.
afercia Aug 30, 2018
488c121
Use a11y speak instead of role alert.
afercia Aug 30, 2018
77597d1
Update the notice readme.
afercia Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update notice readme.
  • Loading branch information
@afercia
afercia committed Aug 30, 2018
commit 51adbbd7847336ee0e0a4b7c9332ed53e05dd59c
2 changes: 1 addition & 1 deletion packages/components/src/notice/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Notice

This component is used to display notices in editor.
This component is used to display notices in the editor. Notices use an ARIA `role="alert"`: they're assertive live regions and will be processed as such by assistive technologies. For this reason, they must be returned directly, without any wrappers.

## Usage

Expand Down