Skip to content

Revert shortcut change in block-deletion e2e test #9477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 2 commits into from
Sep 3, 2018
Merged

Revert shortcut change in block-deletion e2e test #9477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7db5a7
Revert "Update shortcut for remove block in block-deletion test"
talldan Aug 30, 2018
865e9ee
Differentiate shortcut test from backspace test
talldan Sep 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/e2e/specs/block-deletion.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ describe( 'block deletion -', () => {

describe( 'deleting the third block using the Remove Block shortcut', () => {
it( 'results in two remaining blocks and positions the caret at the end of the second block', async () => {
await pressWithModifier( [ 'Shift', META_KEY ], 'Backspace' );
// Type some text to assert that the shortcut also deletes block content.
await page.keyboard.type( 'this is block 2' );
await pressWithModifier( [ 'Alt', META_KEY ], 'Backspace' );
expect( await getEditedPostContent() ).toMatchSnapshot();

// Type additional text and assert that caret position is correct by comparing to snapshot.
Expand Down