Skip to content

Set aspect ratio preserving CSS on embedded content with fixed size iframes #9500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notnownikki merged 10 commits into from
Sep 7, 2018
Merged

Set aspect ratio preserving CSS on embedded content with fixed size iframes #9500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9255d29
Set aspect ratio preserving CSS on previews with fixed size iframes
notnownikki Aug 31, 2018
5baab35
Add aspect ratio CSS.
Sep 4, 2018
fdfa437
Add embed wrapper div in saved content for responsive classes
notnownikki Sep 4, 2018
3720784
Fix things up.
jasmussen Sep 4, 2018
a81372e
Remove the aspect ratio preservation from sandbox
notnownikki Sep 4, 2018
f75ac26
Fix embed tests
notnownikki Sep 4, 2018
6ed5c58
Fix for responsiveness in the editor also.
jasmussen Sep 4, 2018
27c15c7
Fix height for video sandboxing
notnownikki Sep 4, 2018
ea6d484
Make the aspect ratio generic again
notnownikki Sep 4, 2018
037607d
Fix review points
notnownikki Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix embed tests
  • Loading branch information
@notnownikki
notnownikki committed Sep 4, 2018
commit f75ac26bfa96f45652ca0cf9e4669ee25db0df96
4 changes: 3 additions & 1 deletion test/integration/full-content/fixtures/core__embed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<!-- wp:core/embed {"url":"https://example.com/"} -->
<figure class="wp-block-embed">
https://example.com/
<div class="wp-block-embed__wrapper">
https://example.com/
</div>
<figcaption>Embedded content from an example URL</figcaption>
</figure>
<!-- /wp:core/embed -->
2 changes: 1 addition & 1 deletion test/integration/full-content/fixtures/core__embed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
]
},
"innerBlocks": [],
"originalContent": "<figure class=\"wp-block-embed\">\n https://example.com/\n <figcaption>Embedded content from an example URL</figcaption>\n</figure>"
"originalContent": "<figure class=\"wp-block-embed\">\n <div class=\"wp-block-embed__wrapper\">\n https://example.com/\n </div>\n <figcaption>Embedded content from an example URL</figcaption>\n</figure>"
}
]
2 changes: 1 addition & 1 deletion test/integration/full-content/fixtures/core__embed.parsed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"url": "https://example.com/"
},
"innerBlocks": [],
"innerHTML": "\n<figure class=\"wp-block-embed\">\n https://example.com/\n <figcaption>Embedded content from an example URL</figcaption>\n</figure>\n"
"innerHTML": "\n<figure class=\"wp-block-embed\">\n <div class=\"wp-block-embed__wrapper\">\n https://example.com/\n </div>\n <figcaption>Embedded content from an example URL</figcaption>\n</figure>\n"
},
{
"attrs": {},
Expand Down
4 changes: 2 additions & 2 deletions test/integration/full-content/fixtures/core__embed.serialized.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- wp:embed {"url":"https://example.com/"} -->
<figure class="wp-block-embed">
<figure class="wp-block-embed"><div class="wp-block-embed__wrapper">
https://example.com/
<figcaption>Embedded content from an example URL</figcaption></figure>
</div><figcaption>Embedded content from an example URL</figcaption></figure>
<!-- /wp:embed -->