Chrome: Allow adding, removing tags from posts

[youknowriad]

This PR make the TagSelector part of #854.

Worth noting:

• I'm loading the tags in the TagSelector component ( the data discussion not settled yet Our Data Approach #902 )
• A difference with Calypso here is that the API accepts IDs, which means we need to create the posts before assigning them to the post.

[jasmussen]

I like this a lot! I pushed a little CSS polish to the tag chips.

I noticed when you're creating a new tag, there's a brief moment of the tag being blank. Can we insert a placeholder there? Or simply insert the actual tag and just assume that the database call to save the tag succeeds?

[youknowriad]

I guess we need tabs here :)

[youknowriad]

I noticed when you're creating a new tag, there's a brief moment of the tag being blank. Can we insert a placeholder there? Or simply insert the actual tag and just assume that the database call to save the tag succeeds?

I'll take a look

[aduth]

The correct argument name is orderby:

https://developer.wordpress.org/rest-api/reference/tags/#list-tags

[aduth]

Do we want to make a conscious choice between loading "lots" of tags vs. loading "all" the tags (-1)?

[aduth]

Why don't we need to updateSelectedTags on initial mount? Wouldn't a post loaded from save already have tags assigned?

[youknowriad]

but the component won't have the availableTags yet

[aduth]

Do we ever worry the find could return undefined here and throw an error on property access?

[youknowriad]

Not at this moment, because we ensure all the tagNames are loaded before calling this.

[aduth]

Do we actually need or want to save these tags when they're added? AFAIK the post endpoint is happy to create these for us when the post is saved if they don't yet exist, and may actually be the preferred behavior.

[youknowriad]

I tried but failed, which shape should these tags have to do this? The endpoint was giving me an error like tags should be integers (which means ids for me)

[aduth]

Dug around a bit and it appears intentional the endpoint only accepts IDs:

https://github.com/WordPress/WordPress/blob/1d34043/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L2038

[aduth]

How do you feel about a disabled token field instead of a spinner? Is that any better or worse for perceived reactivity?

[youknowriad]

I'll try

[youknowriad]

Tested and approved :)

[nylen]

@youknowriad for the slow TokenField tests I think a reasonable approach is #982 and then find a way to run these regularly outside of Travis.

[youknowriad]

I'll be merging this shortly if no objections?