Skip to content

Support reusable blocks for multi-selection #9732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 6 commits into from
Sep 12, 2018
Merged

Support reusable blocks for multi-selection #9732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4d9758
Support converting a multiselection to a reusable block
youknowriad Sep 10, 2018
42791c9
Add e2e test for multi-selection reusable blocks
youknowriad Sep 10, 2018
10363e2
Remove awareness of `core/template` server-side
youknowriad Sep 10, 2018
66a33d8
Fix unit tests
youknowriad Sep 10, 2018
23a9e98
Update the template block icon
youknowriad Sep 12, 2018
aae9f43
Tweaks per review
youknowriad Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit tests
  • Loading branch information
@youknowriad
youknowriad committed Sep 10, 2018
commit 66a33d8b2d9a259a3694e5cf1c9ecf3277e31292
2 changes: 1 addition & 1 deletion packages/editor/src/store/test/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ describe( 'actions', () => {
const clientId = '358b59ee-bab3-4d6f-8445-e8c6971a5605';
expect( convertBlockToReusable( clientId ) ).toEqual( {
type: 'CONVERT_BLOCK_TO_REUSABLE',
clientId,
clientIds: [ clientId ],
} );
} );
} );
Expand Down
2 changes: 1 addition & 1 deletion test/integration/full-content/full-content.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ describe( 'full post content fixture', () => {
.map( ( block ) => block.name )
// We don't want tests for each oembed provider, which all have the same
// `save` functions and attributes.
.filter( ( name ) => name.indexOf( 'core-embed' ) !== 0 )
.filter( ( name ) => name.indexOf( 'core-embed' ) !== 0 && name !== 'core/template' )
Copy link
Member

@mtias mtias Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the comment here too? Not clear why we need to exclude it.

Copy link
Contributor Author

@youknowriad youknowriad Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to add fixtures for this block. I thought this test would bring too much compared to the e2e test

.forEach( ( name ) => {
const nameToFilename = name.replace( /\//g, '__' );
const foundFixtures = fileBasenames
Expand Down