-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add option to skip PublishSidebar on publishing #9760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b7cc241
Add PrePublish panel option to the general menu tools section
oandregal e3f0c24
Add data API
oandregal 85edadc
Rename PublishPanel to PrePublishPanel
oandregal 0488595
Implement core/edit-post actions and selector
oandregal 14ea423
Rename pre-publish-panel-toggle to publish-sidebar-toggle
oandregal f4c237e
Connect the dots: publish toggles publish sidebar or publish directly
oandregal 1a00c13
Update test for isPublishSidebarEnable preference
oandregal c659529
Expose dismissing option as a checkbox in the sidebar
oandregal e888220
Move publish sidebar logic to core/editor store
oandregal b3e9fa8
docs: tweak comment on isPublishSidebarEnabled
tofumatt f78a332
Use arrow function instead of traditional function
oandregal 3e2877f
Fix linting issue that went undetected by eslint
oandregal dbd6090
Use english apostrophe, not single commas
oandregal ea5dc6a
Make enable/disable actions more obvious
oandregal afae18d
Inline PostPublish button / toggle logic
oandregal 2f45e20
Add padding to align and give it space
oandregal 7bfc2a5
Align to bottom
oandregal c65ea7c
Update wording
oandregal 18036e2
Update copy
oandregal c37b6a8
Tweak microcopy for pre-publish checks.
sarahmonster d1c69c5
Remove outdated docs
oandregal 1be0b54
Preventive measure
oandregal 79ced01
Fix and add tests
oandregal 78ebeec
Add e2e test
oandregal 87b372d
Refactor code to avoid duplication
oandregal acffe70
chore: Tweak styles
tofumatt 37900cc
Disable pre-publish checks after test
oandregal 6637b7e
Add enable/disable functions
oandregal d7c7151
Use specific selector to target pre-publish checks menu item
oandregal b50ca1d
Do not make assumptions about previous states
oandregal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add e2e test
- Loading branch information
commit 78ebeeca0d65ab72b9c3bb949665fea74af082c3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit of a fragile selector, is there anything better/better-named we could use to select the "Don't show this again" checkbox? It looks like
. editor-post-publish-panel__footer input[type=checkbox]would work assumingCheckboxControloutputs an actual checkbox.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved at d7c7151
I was reluctant to introduce a specific selector just for testing but, on a second thought, it's totally worth it in this case. Note also that the code uses the general menu, not the actual checkbox within the publish sidebar. We can't guarantee the publish sidebar is enabled unless we use the general menu.