Skip to content

Try: Remove the sidebar close button on desktop breakpoints #9784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasmussen wants to merge 1 commit into from
Closed

Try: Remove the sidebar close button on desktop breakpoints #9784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions edit-post/components/sidebar/sidebar-header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { withDispatch, withSelect } from '@wordpress/data';
* Internal dependencies
*/
import './style.scss';
import shortcuts from '../../../keyboard-shortcuts';

const SidebarHeader = ( { children, className, closeLabel, closeSidebar, title } ) => {
return (
Expand All @@ -33,12 +32,6 @@ const SidebarHeader = ( { children, className, closeLabel, closeSidebar, title }
</div>
<div className={ classnames( 'components-panel__header edit-post-sidebar-header', className ) }>
{ children }
<IconButton
onClick={ closeSidebar }
icon="no-alt"
label={ closeLabel }
shortcut={ shortcuts.toggleSidebar.display }
/>
</div>
</Fragment>
);
Expand Down
17 changes: 0 additions & 17 deletions edit-post/components/sidebar/sidebar-header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,3 @@
display: none;
}
}

.components-panel__header.edit-post-sidebar-header {
padding-right: $panel-padding / 2;

.components-icon-button {
display: none;
margin-left: auto;

~ .components-icon-button {
margin-left: 0;
}

@include break-medium() {
display: flex;
}
}
}
9 changes: 0 additions & 9 deletions edit-post/components/sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,6 @@
padding-right: $panel-padding / 2;
border-top: 0;
margin-top: 0;

.components-icon-button {
display: none;
margin-left: auto;

@include break-medium() {
display: flex;
}
}
}

.edit-post-sidebar__panel-tab {
Expand Down