Use HTML Document for finding iframe in embed previews #9827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested changes
Sep 12, 2018
| const previewDom = document.createElement( 'div' ); | ||
| previewDom.innerHTML = html; | ||
| const iframe = previewDom.querySelector( 'iframe' ); | ||
| const previewDocument = document.implementation.createHTMLDocument(); |
Member
There was a problem hiding this comment.
The title argument is not optional in IE11:
https://developer.mozilla.org/en-US/docs/Web/API/DOMImplementation/createHTMLDocument#Parameters
Can be solved by just passing '' empty string.
Member
Author
There was a problem hiding this comment.
Fix pushed up. So glad we have you to pick up on these things, I would not have discovered that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for concern highlighted in #9500 (comment)
How has this been tested?
Embed a tweet, embed a youtube video, and check the video has an aspect ratio CSS class applied, and the tweet does not.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)