This repository was archived by the owner on Jul 9, 2018. It is now read-only.
babel-preset-default: Remove babel-plugin-lodash #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: WordPress/gutenberg#5933
This pull request seeks to remove
babel-plugin-lodashfrom the default Babel preset, instead expecting that a consumer would reference Lodash directly by script reference. At worst, the removal of this plugin would bundle all of Lodash into a generated bundle, rather than cherry-picking specific modules. For this reason, it's expected this will be published as a minor release (backward-compatible), not major.This is needed for Gutenberg to continue to use
@wordpress/babel-preset-default, else at least it must be configurable. But with the current direction of core to adopt Lodash as a provided vendor script, it's not expected to need to be an internally-used option to opt for the plugin.