-
Notifications
You must be signed in to change notification settings - Fork 27
Package: Add @wordpress/custom-templated-path-webpack-plugin package
#93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 73.45% 71.36% -2.09%
==========================================
Files 35 38 +3
Lines 437 461 +24
Branches 82 86 +4
==========================================
+ Hits 321 329 +8
- Misses 98 112 +14
- Partials 18 20 +2
Continue to review full report at Codecov.
|
| @@ -0,0 +1,33 @@ | |||
| { | |||
| "name": "@wordpress/custom-templated-path-webpack-plugin", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This initial version here needs to not be 1.0.0, @gziolo has used "version": "1.0.1-0", in the past which has worked fine though I think we should use 1.0.0-alpha.
This all because Lerna bumps this version upon release, if it were to stay at 1.0.0 then Lerna would only be able to publish a patch 1.0.1, minor 1.1.0, or major 2.0.0 release and a 1.0.0 version would never be published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's annoying 😄 Maybe it'd be fine to publish an initial release manually, without Lerna?
| plugins: [ | ||
| new CustomTemplatedPathPlugin( { | ||
| basename( path, data ) { | ||
| console.log(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it wasn’t expected to be landed 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least it's in a test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to add this to jest-console 😎
|
By the way, what was the reason you avoided import/export statements? In src subfolder it’s perfectly fine to use all Babel friendly code. Build step generates 2 versions by default. |
|
Because it doesn't transpile to CommonJS-compatible. If using |
|
Right, that reminds me I sort of did the same for node based packages 😃 |
This pull request seeks to add a new package:
@wordpress/custom-templated-path-webpack-plugin. This has been extracted from an inline class definition in Gutenberg'swebpack.config.js, and updated for Webpack 4+ .Refer to included README.md for more information.
Testing instructions:
See: WordPress/gutenberg#5687