Skip to content

Implement INSERT and UPDATE value type casting #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamziel merged 12 commits into from
Oct 31, 2025
Merged

Implement INSERT and UPDATE value type casting #276

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5a61725
Fix database name used for INSERT and UPDATE in non-strict mode
JanJakes Oct 23, 2025
ab00d0a
Use case-insensitive comparison for INSERT column names
JanJakes Oct 23, 2025
f8c56eb
Improve docs and code readability
JanJakes Oct 23, 2025
51daf2b
Apply INSERT type casting also in STRICT SQL mode
JanJakes Oct 23, 2025
c72af18
Fix YEAR type behavior
JanJakes Oct 24, 2025
503071c
Apply UPDATE type casting also in STRICT SQL mode
JanJakes Oct 29, 2025
a18901b
Fix query tests by MySQL syntax to create schema, not SQLite
JanJakes Oct 29, 2025
951fc45
Improve INSERT and UPDATE error handling
JanJakes Oct 29, 2025
69e1189
Add a fix for a PDO SQLite bug in PHP < 7.3 (#79664)
JanJakes Oct 29, 2025
b7f7921
Fix typos
JanJakes Oct 29, 2025
8bc21a0
Improve method naming and docs
JanJakes Oct 30, 2025
2d1f6b6
Add links to MySQL docs
JanJakes Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix database name used for INSERT and UPDATE in non-strict mode
  • Loading branch information
@JanJakes
JanJakes committed Oct 29, 2025
commit 5a61725848c3edccf1509c51af87944696fe61cf
10 changes: 8 additions & 2 deletions wp-includes/sqlite-ast/class-wp-sqlite-driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4427,6 +4427,9 @@ private function translate_insert_or_replace_body_in_non_strict_mode(
string $table_name,
WP_Parser_Node $node
): string {
// This method is always used with the main database.
$database = $this->get_saved_db_name( $this->main_db_name );

// 1. Get column metadata from information schema.
$is_temporary = $this->information_schema_builder->temporary_table_exists( $table_name );
$columns_table = $this->information_schema_builder->get_table_name( $is_temporary, 'columns' );
Expand All @@ -4438,7 +4441,7 @@ private function translate_insert_or_replace_body_in_non_strict_mode(
AND table_name = ?
ORDER BY ordinal_position
',
array( $this->get_saved_db_name(), $table_name )
array( $database, $table_name )
)->fetchAll( PDO::FETCH_ASSOC );

// 2. Get the list of fields explicitly defined in the INSERT statement.
Expand Down Expand Up @@ -4586,6 +4589,9 @@ function ( $column ) use ( $insert_list ) {
* @return string The translated UPDATE list.
*/
private function translate_update_list_in_non_strict_mode( string $table_name, WP_Parser_Node $node ): string {
// This method is always used with the main database.
$database = $this->get_saved_db_name( $this->main_db_name );

// 1. Get column metadata from information schema.
$is_temporary = $this->information_schema_builder->temporary_table_exists( $table_name );
$columns_table = $this->information_schema_builder->get_table_name( $is_temporary, 'columns' );
Expand All @@ -4596,7 +4602,7 @@ private function translate_update_list_in_non_strict_mode( string $table_name, W
WHERE table_schema = ?
AND table_name = ?
',
array( $this->get_saved_db_name(), $table_name )
array( $database, $table_name )
)->fetchAll( PDO::FETCH_ASSOC );
$column_map = array_combine( array_column( $columns, 'COLUMN_NAME' ), $columns );

Expand Down